Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #865

wants to merge 1 commit into from

Conversation

spa7id
Copy link

@spa7id spa7id commented Nov 19, 2024

No description provided.

@spa7id
Copy link
Author

spa7id commented Nov 19, 2024

1
2
3
4
5

Copy link

@Den-k0 Den-k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +13 to +14
<p>You have visited this page {{ num_visits }}
{% if num_visits == 1 %} time {% else %} times {% endif %} </p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to checklist, better to use pluralize. Good example:
<p>You have visited this page {{ num_visits }} time{{ num_visits|pluralize }}</p>

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Django application! 🎉 While there's a minor syntax error in the urls.py file's import statement, it doesn't significantly impact the overall functionality. Just make sure to correct the import statement to avoid any issues. Keep up the good work and continue improving your coding skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,4 +1,4 @@
from django.urls import path
from django.urls import path, include

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error in the import statement. The include function should be imported separately, not with a comma. You should use from django.urls import path and from django.urls import include on separate lines or combine them correctly with a comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants